Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(kit): normalize (sort) aliases before resolving - #7018

Merged
pi0 merged 1 commit into
mainfrom
fix/sort-aliases
Aug 29, 2022
Merged

fix(kit): normalize (sort) aliases before resolving#7018
pi0 merged 1 commit into
mainfrom
fix/sort-aliases

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14735

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We've already improved Nitro alias handling with some utils from pathe: unjs/pathe#34.

This PR does the same before resolving aliases with kit. (Meaning it can be used with Bridge also.) We can also look at normalizing aliases we pass to vite + webpack in a follow-up PR, but that probably needs a little more testing.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Aug 29, 2022
@danielroe
danielroe requested a review from pi0August 29, 2022 08:31
@danielroedanielroe self-assigned this Aug 29, 2022
@netlify

netlifyBot commented Aug 29, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit022a084
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/630c7969c983d20008715c4d

pi0
pi0 approved these changes Aug 29, 2022
@pi0
pi0 merged commit 33d82b6 into mainAug 29, 2022
@pi0
pi0 deleted the fix/sort-aliases branch August 29, 2022 09:45
@pi0pi0 mentioned this pull request Sep 1, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[kit] resolveAlias should sort keys by length first

2 participants

@danielroe@pi0