Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): remove client manifest.json from public dir - #7021

Merged
pi0 merged 2 commits into
mainfrom
fix/client-manifest
Aug 29, 2022
Merged

fix(vite): remove client manifest.json from public dir#7021
pi0 merged 2 commits into
mainfrom
fix/client-manifest

Conversation

@danielroe

@danielroedanielroe commented Aug 29, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14733

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently, vite manifest gets accidentally included in public assets dir. It is not used and the data within it is incorrect (i.e. non-normalised)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Aug 29, 2022
@danielroe
danielroe requested a review from pi0August 29, 2022 08:58
@danielroedanielroe self-assigned this Aug 29, 2022
@netlify

netlifyBot commented Aug 29, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit53cb044
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/630c884d02ce6400098a49a5

@danielroedanielroe mentioned this pull request Aug 29, 2022
Closed
pi0
pi0 reviewed Aug 29, 2022
View reviewed changes
Comment threadpackages/vite/src/manifest.ts Outdated
pi0
pi0 approved these changes Aug 29, 2022
View reviewed changes
@pi0
pi0 merged commit af2835f into mainAug 29, 2022
@pi0
pi0 deleted the fix/client-manifest branch August 29, 2022 09:37
This was referenced Aug 30, 2022
Closed
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

client manifest is included in public/

2 participants

@danielroe@pi0