Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

perf(nuxt): tree-shake asyncData client logic from server - #7056

Merged
pi0 merged 2 commits into
mainfrom
perf/async-data-client
Aug 30, 2022
Merged

perf(nuxt): tree-shake asyncData client logic from server#7056
pi0 merged 2 commits into
mainfrom
perf/async-data-client

Conversation

@pi0

@pi0pi0 commented Aug 30, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

Extracted from #5738 by @OhB00

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Move the client-only logic to process.client scope so that we are sure bundler can tree-shake it for server also increase code readability since is only used in if condition block.

Co-authored-by: Ohb00 43827372+OhB00@users.noreply.github.com

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 30, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commite122760
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/630deadc0e69c700092a6e9b

Comment threadpackages/nuxt/src/app/composables/asyncData.ts Outdated
@pi0
pi0 merged commit afc9d9b into mainAug 30, 2022
@pi0
pi0 deleted the perf/async-data-client branch August 30, 2022 10:48
This was referenced Aug 30, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pi0@danielroe@DamianGlowala