Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs(deploy): add node cluster mode - #7089

Merged
pi0 merged 11 commits into
nuxt:mainfrom
Mastercuber:patch-1
Sep 5, 2022
Merged

docs(deploy): add node cluster mode#7089
pi0 merged 11 commits into
nuxt:mainfrom
Mastercuber:patch-1

Conversation

@Mastercuber

Copy link
Copy Markdown

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds a section to the docs for starting load balanced network processes with a Node.js internal module.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 30, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitbdc7d65
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6315d4fccbe9550008ca878d
😎 Deploy Previewhttps://deploy-preview-7089--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0

pi0 commented Aug 31, 2022

Copy link
Copy Markdown
Member

Hi @Mastercuber and thanks for nice PR. I've made nitrojs/nitro#451 to introduce cluser as a nitro preset. Would you like to help implementing that?

@pi0pi0 added the pending label Aug 31, 2022
@Mastercuber

Copy link
Copy Markdown
Author

Yes I would like to.
I made me some thoughts about how could a cluster module looks like, but maybe it's better to switch to the issue in unjs.

@pi0

pi0 commented Aug 31, 2022

Copy link
Copy Markdown
Member

Surely. Feel free to share your thoughts in nitrojs/nitro#451 but already a similar usage of current example to implement preset should be amazing start. (we can fork instead of importing btw for cluster)

Comment threaddocs/content/2.guide/5.deploy/1.node-server.md Outdated
@pi0

pi0 commented Aug 31, 2022

Copy link
Copy Markdown
Member

@Mastercuber I think it would be better if you put changes to nitro PR. (I can help on this if you like). This way we can include preset in next release :)

@Mastercuber

Mastercuber commented Aug 31, 2022

Copy link
Copy Markdown
Author

I'm still writing at a comment for 451. The nitro repo is forked and cloned, but I have trouble with pnpm or the registry I use. I will investigate this after finishing the comment. Afterwards I can create a draft PR with the first example code

@pi0pi0 added the documentation Improvements or additions to documentation label Sep 3, 2022
@pi0pi0 changed the title docs(guide): add cluster module sectiondocs(deploy): add node cluster modeSep 5, 2022
@pi0pi0 removed the pending label Sep 5, 2022
@pi0

pi0 commented Sep 5, 2022

Copy link
Copy Markdown
Member

New preset is avialable since nitro 0.5.1 (updating lockfile). Thanks for helping on this 🚀

@pi0
pi0 merged commit fb179ca into nuxt:mainSep 5, 2022
This was referenced Sep 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xdocumentationImprovements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Mastercuber@pi0@stafyniaksacha@danielroe@DamianGlowala