Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxi): display nuxt and nitro versions for dev and build commands - #7118

Merged
pi0 merged 15 commits into
mainfrom
feat/cli-versions
Sep 1, 2022
Merged

feat(nuxi): display nuxt and nitro versions for dev and build commands#7118
pi0 merged 15 commits into
mainfrom
feat/cli-versions

Conversation

@pi0

@pi0pi0 commented Aug 31, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

Resolvesnuxt/nuxt#14703

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

With this PR, we show (installed) versions of Nuxt (it can be different than Nuxi!) and Nitro.

image

Remarks: I used _require instead of getPkg or inference from package.json to ensure we show actually installed versions and use native resolver. This also reduces CLI entry dependencies. Later we should refactor this.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 31, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitcb4c16b
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63107a6f32dd7600091a4c90

@pi0
pi0 marked this pull request as ready for review August 31, 2022 20:16
@pi0
pi0 requested review from antfu, atinux and danielroeAugust 31, 2022 20:23
Comment threadpackages/nuxi/src/utils/banner.ts Outdated
@pi0

pi0 commented Sep 1, 2022

Copy link
Copy Markdown
MemberAuthor

Update: Simplified to only show Nuxt and Nitro versions as original proposal. It was leading to verbosity of showing all sub deps and more complex code. We can always revise to add more info when needed.

@pi0pi0 changed the title feat(nuxi): show versions in dev and build commandsfeat(nuxi): display nuxt and nitro versions for dev and build commandsSep 1, 2022
Comment threadpackages/nuxi/src/utils/banner.ts Outdated
@pi0
pi0 merged commit 2d30a1d into mainSep 1, 2022
@pi0
pi0 deleted the feat/cli-versions branch September 1, 2022 09:34
This was referenced Sep 1, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show nitro version in nuxi info and cli banner

3 participants

@pi0@TheAlexLichter@danielroe