Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxt): add default slot to <NuxtLoadingIndicator> - #7128

Merged
danielroe merged 6 commits into
nuxt:mainfrom
daniil4udo:feature/nuxt-loading-indicator-slot
Oct 10, 2022
Merged

feat(nuxt): add default slot to <NuxtLoadingIndicator>#7128
danielroe merged 6 commits into
nuxt:mainfrom
daniil4udo:feature/nuxt-loading-indicator-slot

Conversation

@daniil4udo

@daniil4udodaniil4udo commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

❓ Type of change

Add slot to the NuxtLoadingIndicator in case user want to add additional element (like spinner)

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Sep 1, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitf7d9354
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63432a2788f82b000842645a
😎 Deploy Previewhttps://deploy-preview-7128--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Comment threaddocs/content/3.api/2.components/4.nuxt-loading-indicator.md Outdated
@daniil4udo
daniil4udoforce-pushed the feature/nuxt-loading-indicator-slot branch 3 times, most recently from ae4f41a to 4660e04CompareSeptember 5, 2022 07:54
@daniil4udo
daniil4udoforce-pushed the feature/nuxt-loading-indicator-slot branch 2 times, most recently from 038332c to be160f2CompareSeptember 13, 2022 20:08
@daniil4udo
daniil4udoforce-pushed the feature/nuxt-loading-indicator-slot branch from be160f2 to f43233eCompareSeptember 14, 2022 08:31
@pi0
pi0force-pushed the main branch 3 times, most recently from 247e18b to c98e5c7CompareSeptember 14, 2022 10:41
@daniil4udo
daniil4udoforce-pushed the feature/nuxt-loading-indicator-slot branch 2 times, most recently from 3550c40 to 3eb8a58CompareSeptember 21, 2022 09:20

@daniil4udodaniil4udo left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniil4udo
daniil4udoforce-pushed the feature/nuxt-loading-indicator-slot branch from 3eb8a58 to d3b9226CompareSeptember 23, 2022 19:57
@danielroedanielroe added enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Oct 9, 2022
@danielroedanielroe changed the title feat(nuxt): add default slot to the NuxtLoadingIndicatorfeat(nuxt): add default slot to <NuxtLoadingIndicator>Oct 10, 2022
@danielroe
danielroe merged commit 75f4a54 into nuxt:mainOct 10, 2022
@danielroedanielroe mentioned this pull request Oct 11, 2022
@daniil4udo
daniil4udo deleted the feature/nuxt-loading-indicator-slot branch November 21, 2022 09:59
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xenhancementNew feature or request🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@daniil4udo@TheAlexLichter@danielroe