Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat: allow extending with theme config - #7131

Merged
pi0 merged 3 commits into
mainfrom
feat/extends-theme-alias
Sep 1, 2022
Merged

feat: allow extending with theme config#7131
pi0 merged 3 commits into
mainfrom
feat/extends-theme-alias

Conversation

@pi0

@pi0pi0 commented Sep 1, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

Resolvesnuxt/nuxt#14329

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR allows extending nuxt app using theme alias config. Typing for theme config in nuxt.config is intentionally set to string while string[] is also possible by c12. This is to guide the correct usage of extends vs theme. Extends from theme has highest layer priority by default too.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Sep 1, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit1bda1dd
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63107ddace31fa0009be221a

@pi0pi0 changed the title feat(kit): allow extending with theme configfeat: allow extending with theme configSep 1, 2022
@pi0
pi0 merged commit 68d12b4 into mainSep 1, 2022
@pi0
pi0 deleted the feat/extends-theme-alias branch September 1, 2022 10:05
@pi0pi0 mentioned this pull request Sep 1, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config alias theme to extends

2 participants

@pi0@danielroe