Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): initialCache: false cache not deleted - #7265

Closed
HomWang wants to merge 18 commits into
nuxt:mainfrom
HomWang:main
Closed

fix(nuxt): initialCache: false cache not deleted#7265
HomWang wants to merge 18 commits into
nuxt:mainfrom
HomWang:main

Conversation

@HomWang

@HomWangHomWang commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Sep 6, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit10e4d87
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63267ec9caea2800099e73d9

@HomWang

Copy link
Copy Markdown
ContributorAuthor

nuxt/nuxt#14813

@HomWang

Copy link
Copy Markdown
ContributorAuthor

Solve the problem that cache data is not deleted when initialCache is false, and there is a large amount of invalid data, which will affect performance. Data should be deleted when onUnmounted to reduce stack and improve performance

@HomWangHomWang changed the title Fix initialCache: falsefix(nuxt): initialCache: false cache not deletedSep 7, 2022
@pi0
pi0force-pushed the main branch 2 times, most recently from 247e18b to c98e5c7CompareSeptember 14, 2022 10:41
@pi0

pi0 commented Nov 10, 2022

Copy link
Copy Markdown
Member

Hi, @516310460 sorry took long to check on this. The initial cache is disabled and removed (#8885).

Releasing data from memory is a good idea. Both from _asyncData and payload.data without cache. At this point, it might introduce unwanted regressions and we are close to the 3.0.0 release.

I have created nuxt/nuxt#15438 to not forget about this enhancement and will ping you after v3 release if interested to help on it.

@pi0pi0 closed this Nov 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@HomWang@pi0@danielroe@CoinPool-Coin