Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(kit): add addImportsSources utility - #7270

Merged
pi0 merged 5 commits into
mainfrom
feat/import-sources
Sep 6, 2022
Merged

feat(kit): add addImportsSources utility#7270
pi0 merged 5 commits into
mainfrom
feat/import-sources

Conversation

@danielroe

@danielroedanielroe commented Sep 6, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

Context: #7158

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds support for auto-imports sources. With deprecation of autoImports:sources hook there is not an easy tool for module authors to add sources without manually passing allowDeprecated themselves.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Sep 6, 2022
@danielroe
danielroe requested review from antfu and pi0September 6, 2022 08:55
@danielroedanielroe self-assigned this Sep 6, 2022
@netlify

netlifyBot commented Sep 6, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit357acb9
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63171e21fd4e4c00083cd723

pi0
pi0 approved these changes Sep 6, 2022
View reviewed changes
@pi0

pi0 commented Sep 6, 2022

Copy link
Copy Markdown
Member

Do you mind to also update deprecation message in nuxt.ts?

pi0
pi0 reviewed Sep 6, 2022
View reviewed changes
Comment threadpackages/nuxt/src/core/nuxt.ts Outdated
@pi0pi0 changed the title feat(kit): add utility to add auto-import sourcesfeat(kit): add addImportsSources utilitySep 6, 2022
@pi0
pi0 merged commit a931667 into mainSep 6, 2022
@pi0
pi0 deleted the feat/import-sources branch September 6, 2022 10:17
This was referenced Sep 9, 2022
Merged
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@antfuantfuAwaiting requested review from antfu
1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xenhancementNew feature or request🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0