Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(webpack): don't parse styles for composable keys - #7333

Merged
pi0 merged 1 commit into
mainfrom
fix/style-parsing
Sep 8, 2022
Merged

fix(webpack): don't parse styles for composable keys#7333
pi0 merged 1 commit into
mainfrom
fix/style-parsing

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14834

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

With webpack, we have some code in a string in the style block, e.g.:

const code = ["\\nconst a ..."]

This wrongly gets parsed by the composable keys, and \\n breaks the parser.

But we shouldn't be parsing code from a style block for automatic useFetch/useState keys, anyway.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working webpack ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Sep 7, 2022
@danielroe
danielroe requested a review from pi0September 7, 2022 20:45
@danielroedanielroe self-assigned this Sep 7, 2022
@netlify

netlifyBot commented Sep 7, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit3a71f1d
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/631902e4c0bad100078f4684

pi0
pi0 approved these changes Sep 8, 2022
@pi0
pi0 merged commit be77d47 into mainSep 8, 2022
@pi0
pi0 deleted the fix/style-parsing branch September 8, 2022 08:55
This was referenced Sep 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working❗ p4-importantPriority 4: bugs that violate documented behavior, or significantly impact perfwebpack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

builder webpack: [unhandledRejection] Expecting Unicode escape sequence \uXXXX

2 participants

@danielroe@pi0