Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): allow abortMiddleware to receive a nuxt error or error options - #7335

Merged
pi0 merged 2 commits into
mainfrom
feat/abort-mw
Sep 8, 2022
Merged

fix(nuxt): allow abortMiddleware to receive a nuxt error or error options#7335
pi0 merged 2 commits into
mainfrom
feat/abort-mw

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#13993

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This is the last piece in the linked issue. It means we can respect a nuxt error thrown in middleware, namely set our own status code/message.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Sep 7, 2022
@danielroe
danielroe requested a review from pi0September 7, 2022 21:40
@danielroedanielroe self-assigned this Sep 7, 2022
@netlify

netlifyBot commented Sep 7, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitfe40ea4
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63190fc33de386000831fcb3

pi0
pi0 approved these changes Sep 8, 2022
@pi0pi0 changed the title feat(nuxt): allow abortMiddleware to receive a nuxt error or error optionsfix(nuxt): allow abortMiddleware to receive a nuxt error or error optionsSep 8, 2022
@pi0
pi0 merged commit 9c3bef4 into mainSep 8, 2022
@pi0
pi0 deleted the feat/abort-mw branch September 8, 2022 08:52
This was referenced Sep 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xenhancementNew feature or request🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Route middleware abortNavigation/navigateTo missing options

2 participants

@danielroe@pi0