fix(vite): allow overriding vite sourcemap

[danielroe]

🔗 Linked issue

resolvesnuxt/nuxt#14840

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Since we started setting sourcemap per-client, per-server, we are overriding the user's choice if they have configured this manually, which they may wish to do.

This respects the value of vite.build.sourcemap if set.

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[netlify]

✅ Deploy Preview for nuxt3-docs canceled.

Name	Link
🔨 Latest commit	6af2c34
🔍 Latest deploy log	https://app.netlify.com/sites/nuxt3-docs/deploys/6319b0d446f78300085455bf

[pi0]

This might be a breaking change but having multiple sources of trust is probably more dangerous to introduce such cases. Any reason we can't rely on one top level sourcemap and flag vite option as never with replacement same as #7317?

[danielroe]

I think issue is that vite allows multiple kinds of sourcemaps. e.g. 'hidden' or 'inline'.

[pi0]

I see. It is same for webpack too actually. I was going to suggest in initial refactor to extend boolean to other string values per type. But in this case, for now it can be enabled with top level sourcemap.client (it is a breaking change) and keep using vite config until we can do that. I don't think implicitly auto enabling client sourcemap was right behavior.

[danielroe]

I'm not sure I understand what you are suggesting. What do you mean by "implicitly auto enabling client sourcemap"? What are you saying the problem is with the previous PR?

[pi0]

No i mean changes with previous PR was right (we just forgot to mark it as breaking change). Before PR, setting vite.build.sourcemap was setting + enabling (new) for both client and server. Now we have dedicated flags for each environment. With changes of this PR, setting vite.build.sourcemap keeps enabling sourcemap even if sourcemap.client is set to false. And we might rely on it's value in other places.

[pi0]

This could be reversed. options.sourcemap.client? config.build.sourcemap : false this way we both respect enabling flags and vite configuration for type.

[danielroe]

Nice solution!