Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): update render if it is invalidated - #7347

Merged
pi0 merged 1 commit into
mainfrom
fix/watchers
Sep 8, 2022
Merged

fix(vite): update render if it is invalidated#7347
pi0 merged 1 commit into
mainfrom
fix/watchers

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14844

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I may be misunderstanding the implementation here, but it seems that we were not updating the render function when it was invalidated. This PR ensures that if the entry is invalidated, we fetch it fresh from the runner.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working dx 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 8, 2022
@danielroe
danielroe requested review from antfu and pi0September 8, 2022 10:00
@danielroedanielroe self-assigned this Sep 8, 2022
@netlify

netlifyBot commented Sep 8, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit5ab6973
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6319bd2704d134000899eedd

pi0
pi0 approved these changes Sep 8, 2022
@pi0

pi0 commented Sep 8, 2022

Copy link
Copy Markdown
Member

LGTM. Waiting for @antfu to confirm.

@pi0

pi0 commented Sep 8, 2022

Copy link
Copy Markdown
Member

Let's try on edge. /cc @antfu please check and tell if id doesn't feel a right fix to you.

@pi0
pi0 merged commit e22bbcc into mainSep 8, 2022
@pi0
pi0 deleted the fix/watchers branch September 8, 2022 14:17
@pi0pi0 mentioned this pull request Sep 9, 2022
@pi0pi0 mentioned this pull request Sep 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't workingdx🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vite-node server watcher not invalidating files

2 participants

@danielroe@pi0