Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(schema): resolve ssr - #7359

Merged
pi0 merged 1 commit into
mainfrom
fix/ssr-inline-plugin
Sep 8, 2022
Merged

fix(schema): resolve ssr#7359
pi0 merged 1 commit into
mainfrom
fix/ssr-inline-plugin

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14847

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This is a hotfix for an upstream issue in untyped which we need to look at (cc: @pi0). get('ssr') was not returning the value in the user's config, but the default value in the config.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Sep 8, 2022
@danielroe
danielroe requested a review from pi0September 8, 2022 14:10
@danielroedanielroe self-assigned this Sep 8, 2022
@netlify

netlifyBot commented Sep 8, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit7383210
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6319f7cb5e53be00087af07e

@pi0
pi0 merged commit d81a742 into mainSep 8, 2022
@pi0
pi0 deleted the fix/ssr-inline-plugin branch September 8, 2022 14:15
This was referenced Sep 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working❗ p4-importantPriority 4: bugs that violate documented behavior, or significantly impact perfvite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RC 10 breaks with vuetify and "ssr:false"

2 participants

@danielroe@pi0