Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): write dev manifest before spa build - #7380

Merged
pi0 merged 2 commits into
mainfrom
fix/spa-manifest
Sep 9, 2022
Merged

fix(vite): write dev manifest before spa build#7380
pi0 merged 2 commits into
mainfrom
fix/spa-manifest

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14861

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We were omitting building client-manifest due to a regression from #7264.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Sep 9, 2022
@danielroe
danielroe requested a review from pi0September 9, 2022 10:27
@danielroedanielroe self-assigned this Sep 9, 2022
@netlify

netlifyBot commented Sep 9, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit2f873dc
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/631b152a87face0008979b70

pi0
pi0 approved these changes Sep 9, 2022
@pi0
pi0 merged commit 0ab29f6 into mainSep 9, 2022
@pi0
pi0 deleted the fix/spa-manifest branch September 9, 2022 10:28
This was referenced Sep 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working❗ p4-importantPriority 4: bugs that violate documented behavior, or significantly impact perfvite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.nuxt/dist folder not created, resulting in an error at runtime (in dev)

2 participants

@danielroe@pi0