Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): use same asset filenames between server and client - #7436

Merged
pi0 merged 1 commit into
mainfrom
fix/vite-server-assets
Sep 12, 2022
Merged

fix(vite): use same asset filenames between server and client#7436
pi0 merged 1 commit into
mainfrom
fix/vite-server-assets

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14878

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

It seems we need to share asset filename generator between server + client so filenames match up between client + server builds.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 12, 2022
@danielroe
danielroe requested a review from pi0September 12, 2022 09:52
@danielroedanielroe self-assigned this Sep 12, 2022
@netlify

netlifyBot commented Sep 12, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitd8cd66e
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/631f0164cd0737000925f86c

pi0
pi0 approved these changes Sep 12, 2022
@pi0pi0 changed the title fix(vite): share asset filenames between server + clientfix(vite): use same asset filenames between server and clientSep 12, 2022
@pi0
pi0 merged commit d507816 into mainSep 12, 2022
@pi0
pi0 deleted the fix/vite-server-assets branch September 12, 2022 10:12
This was referenced Sep 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagevite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nuxt 3 rc 9 renders all @ symbol in assets url in ssr incorrectly and results in 404

2 participants

@danielroe@pi0