Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxt): add workspaceDir option and add it to modulesDir - #7439

Merged
pi0 merged 5 commits into
mainfrom
feat/workspace-dir
Sep 12, 2022
Merged

feat(nuxt): add workspaceDir option and add it to modulesDir#7439
pi0 merged 5 commits into
mainfrom
feat/workspace-dir

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#11074

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds workspaceDir as an option in nuxt config. By default it uses pkg-types to locate this directory.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Sep 12, 2022
@danielroe
danielroe requested a review from pi0September 12, 2022 11:18
@danielroedanielroe self-assigned this Sep 12, 2022
@netlify

netlifyBot commented Sep 12, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commite0002cc
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/631f89513b0e810009dc6033

Comment threadpackages/schema/src/config/_common.ts Outdated
@pi0

pi0 commented Sep 12, 2022

Copy link
Copy Markdown
Member

Would be nice if in same PR, we can sync workpaceDir to the nitro config as well (releasing next version shortly)

@danielroe

Copy link
Copy Markdown
MemberAuthor

Great! Will update shortly. I think I already added the option in Nitro config in this PR (though it won't be effective until next Nitro version).

@danielroe
danielroe requested a review from pi0September 12, 2022 19:40
@pi0
pi0 merged commit 3753ea0 into mainSep 12, 2022
@pi0
pi0 deleted the feat/workspace-dir branch September 12, 2022 20:06
This was referenced Sep 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xenhancementNew feature or request🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workspaceDir

2 participants

@danielroe@pi0