Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): augment GlobalComponents from @vue/runtime-core - #7448

Merged
pi0 merged 1 commit into
mainfrom
fix/webstorm-global-components
Sep 12, 2022
Merged

fix(nuxt): augment GlobalComponents from @vue/runtime-core#7448
pi0 merged 1 commit into
mainfrom
fix/webstorm-global-components

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/nuxt#13007

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This may make Webstorm happier with our auto-imported components; it doesn't affect volar/vscode/vue-tsc, which actually says that this is what we should do: https://github.com/johnsoncodehk/volar/blob/b1896bbd0cb23ea35b73ad2c232b0a6832f70939/docs/features.md#global-components.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added types 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 12, 2022
@danielroe
danielroe requested a review from pi0September 12, 2022 13:07
@danielroedanielroe self-assigned this Sep 12, 2022
@netlify

netlifyBot commented Sep 12, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit7493a4b
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/631f2f1911d9990009fc1c2e

pi0
pi0 approved these changes Sep 12, 2022
@pi0
pi0 merged commit 5893dc2 into mainSep 12, 2022
@pi0
pi0 deleted the fix/webstorm-global-components branch September 12, 2022 13:40
This was referenced Sep 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagetypes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0