Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

perf(nuxt): only inject preload helper when webpack is used - #7460

Merged
pi0 merged 2 commits into
mainfrom
perf/preload-tidy
Sep 13, 2022
Merged

perf(nuxt): only inject preload helper when webpack is used#7460
pi0 merged 2 commits into
mainfrom
perf/preload-tidy

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This started out as a simple small perf improvement but ended up fixing a couple of bugs as well. The changes are:

  • only inject the server preload plugin when webpack builder is used (it adds a needless overhead with vite)
  • update NuxtOptions schema so it correctly shows resolved value of builder
  • update resolver for builder so it respects a custom builder value

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing performance labels Sep 12, 2022
@danielroe
danielroe requested a review from pi0September 12, 2022 22:12
@danielroedanielroe self-assigned this Sep 12, 2022
@netlify

netlifyBot commented Sep 12, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit50cc1e1
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/631fafb869f4df000985e246

pi0
pi0 approved these changes Sep 13, 2022
@pi0
pi0 merged commit 31de181 into mainSep 13, 2022
@pi0
pi0 deleted the perf/preload-tidy branch September 13, 2022 10:57
This was referenced Sep 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't workingenhancementNew feature or request🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressingperformance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0