Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): pass fully resolved path to nitro dist files - #7494

Merged
pi0 merged 11 commits into
mainfrom
fix/inline-dist
Sep 15, 2022
Merged

fix(nuxt): pass fully resolved path to nitro dist files#7494
pi0 merged 11 commits into
mainfrom
fix/inline-dist

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14753

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR improves the testing for inlining nuxt assets in the build:

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 14, 2022
@danielroe
danielroe requested a review from pi0September 14, 2022 10:10
@danielroedanielroe self-assigned this Sep 14, 2022
@netlify

netlifyBot commented Sep 14, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit5be35d2
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6322e6d2821a1500088ca1bb

@pi0
pi0force-pushed the main branch 3 times, most recently from 247e18b to c98e5c7CompareSeptember 14, 2022 10:41
@danielroe
danielroe marked this pull request as draft September 14, 2022 14:13
Comment threadpackages/nuxt/src/core/nitro.ts
Comment threadpackages/vite/src/server.ts
Comment threadpackages/vite/src/server.ts Outdated
@danielroe
danielroe marked this pull request as ready for review September 15, 2022 08:55
@danielroe

Copy link
Copy Markdown
MemberAuthor

I would like to iterate on this (moving some of this to build.transpile for example), but would be good to merge so https://github.com/vitejs/vite-ecosystem-ci will keep doing its good work.

pi0
pi0 approved these changes Sep 15, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM (i had been pending it for rc.11 to try on edge)

'nuxt/dist',
'nuxt3/dist'
'nuxt3/dist',
distDir

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to exclude dist dir for prerender (will come with another PR if needed)

@pi0
pi0 merged commit 5855ba4 into mainSep 15, 2022
@pi0
pi0 deleted the fix/inline-dist branch September 15, 2022 11:24
@pi0pi0 mentioned this pull request Sep 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nuxt/app is treated as an external

2 participants

@danielroe@pi0