Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxt): generate spa fallbacks for nuxt generate - #7507

Merged
pi0 merged 2 commits into
mainfrom
feat/200.html
Sep 14, 2022
Merged

feat(nuxt): generate spa fallbacks for nuxt generate#7507
pi0 merged 2 commits into
mainfrom
feat/200.html

Conversation

@pi0

@pi0pi0 commented Sep 14, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

Resolvesnuxt/nuxt#13990

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR generates fallback SPA page for nuxt generate (ssr: true) in order to make fallback supported.

  • nuxt: generate + ssr: true (default): 200.html is generated (new) without being server-side rendered.
  • nuxt: generate + ssr: false: 200.html, 404.html and index.html (new) are generated

Nitro prerenderer detects this explicit routes and disable SSR for them. To avoid confusing with actually prerendering top level /, index.html is only pre-rendered for ssr: false. Also 404.html is only generated for ssr: false. It can be added for ssr: true using nitro.prerender.routes: ['/404.html'] if needed.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Sep 14, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit90768e8
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6321ef125480d7000873be3a

@pi0pi0 changed the title feat(nuxt): generate spa fallback for nuxt generatefeat(nuxt): generate spa fallbacks for nuxt generateSep 14, 2022
@pi0
pi0 merged commit 9ee5ca2 into mainSep 14, 2022
@pi0
pi0 deleted the feat/200.html branch September 14, 2022 15:16
This was referenced Sep 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SSG] No 200.html is being rendered

2 participants

@pi0@danielroe