Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

chore: update examples to ^3.0.0-rc.10 and use global defineNuxtConfig - #7515

Merged
pi0 merged 4 commits into
mainfrom
docs/config-import
Sep 14, 2022
Merged

chore: update examples to ^3.0.0-rc.10 and use global defineNuxtConfig#7515
pi0 merged 4 commits into
mainfrom
docs/config-import

Conversation

@pi0

@pi0pi0 commented Sep 14, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

##7497

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Sep 14, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitbea83e9
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63220e4d12af6a00087eba4f
😎 Deploy Previewhttps://deploy-preview-7515--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0pi0 changed the title docs: update example to ^3.0.0-rc.10 and use defineNuxtConfig auto importchore: update examples to ^3.0.0-rc.10 and use defineNuxtConfig auto importSep 14, 2022
@darthf1

Copy link
Copy Markdown

Is it possible to keep the imports somewhere, but with a comment it can be omitted in case of auto import?

It's my understanding now auto imports can be disabled, having the import path visible is still useful. But please correct me if Im wrong.

@pi0

pi0 commented Sep 14, 2022

Copy link
Copy Markdown
MemberAuthor

It's my understanding now auto imports can be disabled, having the import path visible is still useful. But please correct me if Im wrong.

Feature to disable auto imports is related to runtime bundler. We always have defineNuxtConfig available (check linked PR). But of course you can choose to explicitly import from 'nuxt/config'

@darthf1

Copy link
Copy Markdown

It's my understanding now auto imports can be disabled, having the import path visible is still useful. But please correct me if Im wrong.

Feature to disable auto imports is related to runtime bundler. We always have defineNuxtConfig available (check linked PR). But of course you can choose to explicitly import from 'nuxt/config'

Ah ok! Thanks for the clarification.

Since this PR is to remove all the references to this import from the docs (since it can be auto imported), how is a user (who prefers manual imports) going to know / learn what the import path is? Is it possible to keep one reference somewhere in the docs?

@pi0

pi0 commented Sep 14, 2022

Copy link
Copy Markdown
MemberAuthor

Added explicit docs. Nice suggestion 👍🏼

@pi0pi0 changed the title chore: update examples to ^3.0.0-rc.10 and use defineNuxtConfig auto importchore: update examples to ^3.0.0-rc.10 and use global defineNuxtConfigSep 14, 2022
@pi0
pi0 merged commit 5973df1 into mainSep 14, 2022
@pi0
pi0 deleted the docs/config-import branch September 14, 2022 17:26
@darthf1

Copy link
Copy Markdown

Added explicit docs. Nice suggestion 👍🏼

Awesome. Thank you for making the changes.

@pi0pi0 mentioned this pull request Sep 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pi0@darthf1@atinux@danielroe