Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(schema): update resolver for cssSourceMap to new sourcemap - #7541

Merged
pi0 merged 1 commit into
mainfrom
fix/css-sourcemap-default
Sep 15, 2022
Merged

fix(schema): update resolver for cssSourceMap to new sourcemap#7541
pi0 merged 1 commit into
mainfrom
fix/css-sourcemap-default

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This should only affect typings for Bridge, but we hadn't updated the get('sourcemap') call.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working types 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Sep 15, 2022
@danielroe
danielroe requested a review from pi0September 15, 2022 09:03
@danielroedanielroe self-assigned this Sep 15, 2022
@netlify

netlifyBot commented Sep 15, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitf18f98d
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6322ea66f91aa60008894f0c

@pi0pi0 added the bridge label Sep 15, 2022
pi0
pi0 approved these changes Sep 15, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to split v2 schema resolution in next versions and move it to bridge directly...

@pi0
pi0 merged commit b2f147d into mainSep 15, 2022
@pi0
pi0 deleted the fix/css-sourcemap-default branch September 15, 2022 11:10
@pi0pi0 mentioned this pull request Sep 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbridgebugSomething isn't working🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressingtypes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0