Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxi, vite): ipv6 support for nuxi dev - #7560

Merged
pi0 merged 3 commits into
mainfrom
fix/ipv6
Sep 15, 2022
Merged

fix(nuxi, vite): ipv6 support for nuxi dev#7560
pi0 merged 3 commits into
mainfrom
fix/ipv6

Conversation

@pi0

@pi0pi0 commented Sep 15, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14826

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Add support for IPv6. Previously generated URLs were broken.

Listhen fix: unjs/listhen@eb9f5ef)

This PR adds new server.url which is directly formatted from listhen for vite-node.

HOST=::1 yarn nuxt dev playground

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Sep 15, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit6e285f4
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/632333348b37750008f47cb3

@pi0
pi0 marked this pull request as draft September 15, 2022 13:58
@pi0pi0 changed the title fix(nuxi): ipv6 support for nuxi devfix(nuxi, vite): ipv6 support for nuxi devSep 15, 2022
@pi0
pi0 marked this pull request as ready for review September 15, 2022 14:14

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@pi0
pi0 merged commit 43b9bca into mainSep 15, 2022
@pi0
pi0 deleted the fix/ipv6 branch September 15, 2022 16:10
@pi0pi0 mentioned this pull request Sep 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ipv6 host is not supported for nuxi dev

2 participants

@pi0@danielroe