Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxi): print resolved public directory after generate - #7577

Merged
pi0 merged 2 commits into
mainfrom
fix/generate-dir
Sep 16, 2022
Merged

fix(nuxi): print resolved public directory after generate#7577
pi0 merged 2 commits into
mainfrom
fix/generate-dir

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14903

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Using new useNitro utility (#7557) we can access the resolved publicDir for nitro and print the relative path to it, rather than hard coding .output/public.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working cli 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 15, 2022
@danielroe
danielroe requested a review from pi0September 15, 2022 23:27
@danielroedanielroe self-assigned this Sep 15, 2022
@netlify

netlifyBot commented Sep 15, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitc72701e
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/632439a56f3cdc000844086a

Comment threadpackages/nuxi/src/commands/build.ts Outdated
Comment threadpackages/nuxi/src/commands/build.ts
pi0
pi0 approved these changes Sep 16, 2022
@pi0
pi0 merged commit f0ad1b0 into mainSep 16, 2022
@pi0
pi0 deleted the fix/generate-dir branch September 16, 2022 09:26
@pi0pi0 mentioned this pull request Sep 20, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't workingcli🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output directory message mismatch confi

2 participants

@danielroe@pi0