Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): normalize vite-node error data - #7589

Merged
pi0 merged 2 commits into
mainfrom
fix/vite-node-error
Sep 16, 2022
Merged

fix(vite): normalize vite-node error data#7589
pi0 merged 2 commits into
mainfrom
fix/vite-node-error

Conversation

@pi0

@pi0pi0 commented Sep 16, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14909

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

There are vast different possibilities from errors rollup and vite throw. Since vite-node tries to make a network request to fetch the modules, we were missing some information (such as module id). This PR tries to normalize it beforehand.

image

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Sep 16, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit3f5781d
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6324b29ea701ce000833bf96

@pi0
pi0 marked this pull request as draft September 16, 2022 10:13
@pi0
pi0 marked this pull request as ready for review September 16, 2022 17:41
@pi0
pi0 merged commit cfaca9c into mainSep 16, 2022
@pi0
pi0 deleted the fix/vite-node-error branch September 16, 2022 17:43
@pi0pi0 mentioned this pull request Sep 20, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[vite-node] [ERR_MODULE_NOT_FOUND]

2 participants

@pi0@danielroe