Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite, webpack): handle auto keys for composables without args - #7651

Merged
pi0 merged 1 commit into
mainfrom
fix/undefined-args
Sep 19, 2022
Merged

fix(vite, webpack): handle auto keys for composables without args#7651
pi0 merged 1 commit into
mainfrom
fix/undefined-args

Conversation

@danielroe

@danielroedanielroe commented Sep 19, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

A regression in earlier composable keys fix.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite webpack 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 19, 2022
@danielroe
danielroe requested a review from pi0September 19, 2022 14:43
@danielroedanielroe self-assigned this Sep 19, 2022
@netlify

netlifyBot commented Sep 19, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitcd320ab
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6328801a49e6380008bad360

pi0
pi0 approved these changes Sep 19, 2022
View reviewed changes
@pi0

pi0 commented Sep 19, 2022

Copy link
Copy Markdown
Member

Do you mind to attach an example only for future reference?

@pi0pi0 changed the title fix(vite, webpack): don't assume args are definedfix(vite, webpack): handle auto keys for composables without argsSep 19, 2022
@pi0
pi0 merged commit 42cf48e into mainSep 19, 2022
@pi0
pi0 deleted the fix/undefined-args branch September 19, 2022 14:45
@danielroe

danielroe commented Sep 19, 2022

Copy link
Copy Markdown
MemberAuthor
conststate=useState()// no args

@pi0pi0 mentioned this pull request Sep 20, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagevitewebpack

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0