Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): don't treeshake client-only fallback templates - #7659

Merged
pi0 merged 1 commit into
mainfrom
fix/client-only-fallback
Sep 20, 2022
Merged

fix(nuxt): don't treeshake client-only fallback templates#7659
pi0 merged 1 commit into
mainfrom
fix/client-only-fallback

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14896

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This is an alternative approach to #7527, using pure regexp to handle fallback/placeholder slots.

It also fixes a bug where we matched partial component names.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 19, 2022
@danielroe
danielroe requested a review from pi0September 19, 2022 21:24
@danielroedanielroe self-assigned this Sep 19, 2022
@netlify

netlifyBot commented Sep 19, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commita4a7638
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6328de2d5a62e50008b9f638

@pi0
pi0 merged commit f8a2356 into mainSep 20, 2022
@pi0
pi0 deleted the fix/client-only-fallback branch September 20, 2022 06:24
@pi0pi0 mentioned this pull request Sep 20, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<ClientOnly> with <template #fallback> always results in hydration error in RC10

2 participants

@danielroe@pi0