Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): only observe tag elements for <NuxtLink> prefetching - #7679

Merged
pi0 merged 1 commit into
mainfrom
fix/custom-observe
Sep 20, 2022
Merged

fix(nuxt): only observe tag elements for <NuxtLink> prefetching#7679
pi0 merged 1 commit into
mainfrom
fix/custom-observe

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14899

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

It's possible that NuxtLink doesn't render an HTML element; we can skip observing it in this case and leave the user to implement prefetching on their own.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 20, 2022
@danielroe
danielroe requested a review from pi0September 20, 2022 09:25
@danielroedanielroe self-assigned this Sep 20, 2022
@netlify

netlifyBot commented Sep 20, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit98dd11b
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63298721b26d4c0008f126dd

pi0
pi0 approved these changes Sep 20, 2022
@pi0pi0 changed the title fix(nuxt): only observe elements, not comments or text nodesfix(nuxt): only observe tag elements for <NuxtLink> prefetchingSep 20, 2022
@pi0
pi0 merged commit 98ce2e6 into mainSep 20, 2022
@pi0
pi0 deleted the fix/custom-observe branch September 20, 2022 09:29
@pi0pi0 mentioned this pull request Sep 20, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nuxt-Link issue in rc-10

2 participants

@danielroe@pi0