Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs: recommend to not overwrite some keys in tsconfig - #7717

Merged
pi0 merged 2 commits into
nuxt:mainfrom
tobiasdiez:patch-1
Sep 21, 2022
Merged

docs: recommend to not overwrite some keys in tsconfig#7717
pi0 merged 2 commits into
nuxt:mainfrom
tobiasdiez:patch-1

Conversation

@tobiasdiez

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I hit a strange error while upgrading from rc 9 to 11 that import_meta.hot.accept was not defined. After a bit of research, I think, I hit evanw/esbuild#2294. At least after removing "target": "ES2018", from the tsconfig file everything is working smoothly now. So I added a small note to the docs that these keys shouldn't be overwritten.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Sep 21, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commite7d9aa1
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/632b18fdc96a6a00098b679e
😎 Deploy Previewhttps://deploy-preview-7717--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroedanielroe added the documentation Improvements or additions to documentation label Sep 21, 2022
Comment threaddocs/content/2.guide/2.directory-structure/3.tsconfig.md Outdated
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
pi0
pi0 approved these changes Sep 21, 2022
@pi0
pi0 merged commit daf99c3 into nuxt:mainSep 21, 2022
@pi0

pi0 commented Sep 21, 2022

Copy link
Copy Markdown
Member

Thanks!

@tobiasdiez
tobiasdiez deleted the patch-1 branch September 21, 2022 14:31
@danielroedanielroe mentioned this pull request Oct 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xdocumentationImprovements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasdiez@pi0@danielroe@DamianGlowala