Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): respect immediate option in useFetch - #7720

Merged
pi0 merged 1 commit into
mainfrom
fix/immediate-fetch
Sep 22, 2022
Merged

fix(nuxt): respect immediate option in useFetch#7720
pi0 merged 1 commit into
mainfrom
fix/immediate-fetch

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14982

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We were not passing immediate from useFetch -> useAsyncData.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 21, 2022
@danielroe
danielroe requested a review from pi0September 21, 2022 11:09
@danielroedanielroe self-assigned this Sep 21, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Sep 21, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitca97b3f
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/632af0e37051f4000857e38d
😎 Deploy Previewhttps://deploy-preview-7720--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pi0
pi0 approved these changes Sep 22, 2022
@pi0
pi0 merged commit 2894a75 into mainSep 22, 2022
@pi0
pi0 deleted the fix/immediate-fetch branch September 22, 2022 13:55
@danielroedanielroe mentioned this pull request Oct 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useFetch() option immediate = false does't not stop the request from being made immediately

2 participants

@danielroe@pi0