Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): don't disable scripts in dev mode with experimental noScripts - #7745

Merged
pi0 merged 1 commit into
mainfrom
fix/dev-no-scripts
Sep 26, 2022
Merged

fix(nuxt): don't disable scripts in dev mode with experimental noScripts#7745
pi0 merged 1 commit into
mainfrom
fix/dev-no-scripts

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15000

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We should only respect experimental.noScripts in built mode.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 22, 2022
@danielroe
danielroe requested a review from pi0September 22, 2022 08:08
@danielroedanielroe self-assigned this Sep 22, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Sep 22, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit57c7382
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/632c17e8f3a2610008869926
😎 Deploy Previewhttps://deploy-preview-7745--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0

pi0 commented Sep 22, 2022

Copy link
Copy Markdown
Member

Doesn't it make sense to have consistent behavior between dev and prod for disabling scripts?

@danielroe

Copy link
Copy Markdown
MemberAuthor

We are testing for dev here:

if(nuxt.options.experimental.noScripts&&!nuxt.options.dev){

I think HMR for dev, but no scripts for built site seems a better default, but happy to be convinced otherwise.

pi0
pi0 approved these changes Sep 26, 2022
@pi0pi0 changed the title fix(nuxt): don't disable scripts in dev modefix(nuxt): don't disable scripts in dev mode with experimental noScriptsSep 26, 2022
@pi0
pi0 merged commit 4c50488 into mainSep 26, 2022
@pi0
pi0 deleted the fix/dev-no-scripts branch September 26, 2022 09:52
@danielroedanielroe mentioned this pull request Oct 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Experemental noScripts

2 participants

@danielroe@pi0