Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxt): support redirect within page metadata - #7746

Merged
pi0 merged 2 commits into
mainfrom
feat/metadata-redirect
Sep 22, 2022
Merged

feat(nuxt): support redirect within page metadata#7746
pi0 merged 2 commits into
mainfrom
feat/metadata-redirect

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14075

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR:

  • supports redirect (as well as alias) in page metadata
  • adds types for redirect within extend:pages
  • updates types for redirect + alias in page metadata
  • adds some tests for the behaviour

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Sep 22, 2022
@danielroe
danielroe requested a review from pi0September 22, 2022 08:29
@danielroedanielroe self-assigned this Sep 22, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Sep 22, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit8706b67
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/632c1ceb3a21ed0008e9b1f5
😎 Deploy Previewhttps://deploy-preview-7746--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pi0
pi0 approved these changes Sep 22, 2022
@pi0
pi0 merged commit 1c26e07 into mainSep 22, 2022
@pi0
pi0 deleted the feat/metadata-redirect branch September 22, 2022 13:54
@danielroedanielroe mentioned this pull request Sep 28, 2022
7 tasks
@danielroedanielroe mentioned this pull request Oct 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xenhancementNew feature or request🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow specifying redirect in definePageMeta

2 participants

@danielroe@pi0