Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): do not warn for non-existent default layout - #7748

Merged
pi0 merged 1 commit into
mainfrom
fix/empty-layout-warning
Sep 22, 2022
Merged

fix(nuxt): do not warn for non-existent default layout#7748
pi0 merged 1 commit into
mainfrom
fix/empty-layout-warning

Conversation

@danielroe

@danielroedanielroe commented Sep 22, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

reported by @ckald in nuxt/nuxt#14818

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

In the case of a non-existent default layout (such as when user did not have a custom app.vue but had ~/pages) we were wrongly warning about DOM nodes, despite no transition being rendered. This PR ignores this case.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Sep 22, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitf589fe5
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/632c21ce13f0440009b85e4f
😎 Deploy Previewhttps://deploy-preview-7748--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroedanielroe self-assigned this Sep 22, 2022
@danielroe
danielroe requested a review from pi0September 22, 2022 08:51
@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage dx 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing and removed 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 22, 2022
pi0
pi0 approved these changes Sep 22, 2022
@pi0
pi0 merged commit b68cf07 into mainSep 22, 2022
@pi0
pi0 deleted the fix/empty-layout-warning branch September 22, 2022 13:54
@danielroedanielroe mentioned this pull request Oct 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't workingdx🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0