Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs: add newline at end of sass import - #7810

Merged
atinux merged 2 commits into
nuxt:mainfrom
Fumihiro-Yano:patch-1
Sep 30, 2022
Merged

docs: add newline at end of sass import#7810
atinux merged 2 commits into
nuxt:mainfrom
Fumihiro-Yano:patch-1

Conversation

@Fumihiro-Yano

@Fumihiro-YanoFumihiro-Yano commented Sep 25, 2022•
edited by DamianGlowala
Loading

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Sass import needs newline code.

The following error will be displayed if the line feed code is within

[sass] expected newline. ╷
1 │ @use "@/assets/_colors.sass" as *abbr,
│ ^
╵
assets/styles/reset.sass 1:39 root stylesheet

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Fumihiro-Yano
【Update】Sass import needs newline code.
4b58791
Sass import needs newline code.
The following error will be displayed if the line feed code is within
```
[sass] expected newline. ╷
1 │ @use "@/assets/_colors.sass" as *abbr,
│ ^
╵
assets/styles/reset.sass 1:39 root stylesheet
```
@codesandbox

codesandboxBot commented Sep 25, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Sep 25, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit550cdd6
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/633186c7e6ee8a0008577f5a
😎 Deploy Previewhttps://deploy-preview-7810--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Fumihiro-YanoFumihiro-Yano changed the title 【Update】Sass import needs newline code.docs: Sass import needs newline code.Sep 25, 2022
@Fumihiro-YanoFumihiro-Yano changed the title docs: Sass import needs newline code.docs: sass import needs newline code.Sep 25, 2022
@DamianGlowalaDamianGlowala changed the title docs: sass import needs newline code.docs: Sass import needs newline characterSep 25, 2022
@DamianGlowalaDamianGlowala added the documentation Improvements or additions to documentation label Sep 25, 2022
@danielroedanielroe changed the title docs: Sass import needs newline characterdocs: add newline at end of sass importSep 25, 2022
@DamianGlowala

DamianGlowala commented Sep 26, 2022

Copy link
Copy Markdown
Member

I'm wondering whether the whitespace prepending \n is needed?

danielroe
danielroe reviewed Sep 26, 2022
View reviewed changes
Comment threaddocs/content/1.getting-started/4.assets.md Outdated
@atinux
atinux merged commit bea2848 into nuxt:mainSep 30, 2022
@Fumihiro-Yano
Fumihiro-Yano deleted the patch-1 branch October 4, 2022 04:40
@danielroedanielroe mentioned this pull request Oct 9, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@danielroedanielroedanielroe approved these changes
@atinuxatinuxatinux approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.xdocumentationImprovements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Fumihiro-Yano@DamianGlowala@atinux@danielroe