Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): don't prerender index.html with a server - #7831

Merged
atinux merged 6 commits into
mainfrom
fix/not-index
Oct 3, 2022
Merged

fix(nuxt): don't prerender index.html with a server#7831
atinux merged 6 commits into
mainfrom
fix/not-index

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15016

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We should not be prerendering index.html if there is a dynamic server as runtime config (or nitro plugins) may change the response.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 26, 2022
@danielroe
danielroe requested a review from pi0September 26, 2022 11:02
@danielroedanielroe self-assigned this Sep 26, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Sep 26, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit83812d0
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/633aeb46ba9fd40009651aba

@LastxTemplar

Copy link
Copy Markdown

I would just like to say that this is not a minor bug, it's an app breaking bug. We have the ssr flag set to false but it still generates the index page and our runtime env values are not available in there. This breaks the app especially if you have middleware using a service like auth0. Can this please be merge as soon as possible? or at least provide a workaround to forcefully not generate the index page.
Thank you!

@TheAlexLichter

Copy link
Copy Markdown
Member

@LastxTemplar see nuxt/nuxt#15016 for a workaround.

@LastxTemplar

Copy link
Copy Markdown

@LastxTemplar see nuxt/nuxt#15016 for a workaround.

Thank you!

@danielroe

Copy link
Copy Markdown
MemberAuthor

I would also add that when I mark something p3 vs p4 it doesn't mean it will get less attention. For me, it's:

(num people affected) x (severity of the issue) - (possibility of workaround)

@vercel
vercelBot temporarily deployed to Preview October 3, 2022 14:15 Inactive
@atinux
atinux merged commit 92ff066 into mainOct 3, 2022
@atinux
atinux deleted the fix/not-index branch October 3, 2022 14:17
@danielroedanielroe mentioned this pull request Oct 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Public runtimeConfig not working on index page

4 participants

@danielroe@LastxTemplar@TheAlexLichter@atinux