Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(test-utils): respect setupTimeout - #7866

Merged
atinux merged 1 commit into
mainfrom
fix/test-timeout
Oct 3, 2022
Merged

fix(test-utils): respect setupTimeout#7866
atinux merged 1 commit into
mainfrom
fix/test-timeout

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14159

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Previously we were not doing anything with setupTimeout, but hard coding the setup length.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage test-utils labels Sep 27, 2022
@danielroe
danielroe requested a review from pi0September 27, 2022 13:55
@danielroedanielroe self-assigned this Sep 27, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Sep 27, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit1b83a9b
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/633300be9a3b3e0008356e9c

@atinux
atinux self-requested a review September 27, 2022 14:26
@atinux
atinux merged commit dab1b11 into mainOct 3, 2022
@atinux
atinux deleted the fix/test-timeout branch October 3, 2022 13:48
@danielroedanielroe mentioned this pull request Oct 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagetest-utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implement setupTimeout option in test-utils

2 participants

@danielroe@atinux