Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): add type-checker to client build for ssr: false - #7930

Merged
atinux merged 2 commits into
mainfrom
fix/typecheck-spa
Oct 3, 2022
Merged

fix(vite): add type-checker to client build for ssr: false#7930
atinux merged 2 commits into
mainfrom
fix/typecheck-spa

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14586

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

If there is no server build, currently type checker isn't applied. This PR falls back to checking client build.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added the bug Something isn't working label Sep 30, 2022
@danielroe
danielroe requested a review from pi0September 30, 2022 13:22
@danielroedanielroe self-assigned this Sep 30, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Sep 30, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit8e0d3fc
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/633ae558ebc5da0008178e81

@atinux
atinux merged commit d25dafe into mainOct 3, 2022
@atinux
atinux deleted the fix/typecheck-spa branch October 3, 2022 13:37
@danielroedanielroe mentioned this pull request Oct 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

typeCheck only handles server build

2 participants

@danielroe@atinux