Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(schema): add experimental routeRules - #7954

Merged
pi0 merged 9 commits into
mainfrom
feat/schema-alias
Oct 17, 2022
Merged

feat(schema): add experimental routeRules#7954
pi0 merged 9 commits into
mainfrom
feat/schema-alias

Conversation

@danielroe

@danielroedanielroe commented Oct 2, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

https://github.com/nuxt/framework/discussions/560

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This allows specifying a top-level routes option for route rules. Given how prominent this feature might end up being, I think the DX is worth it.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added nitro schema 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Oct 2, 2022
@danielroe
danielroe requested a review from pi0October 2, 2022 12:43
@danielroedanielroe self-assigned this Oct 2, 2022
@codesandbox

codesandboxBot commented Oct 2, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 2, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit95554ca
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/634d3aa0ea2a5a0008aada40

@vercel
vercelBot temporarily deployed to Preview October 2, 2022 12:43 Inactive
danielroe
danielroe commented Oct 2, 2022
View reviewed changes
Comment threadpackages/schema/src/config/nitro.ts Outdated
@vercel
vercelBot temporarily deployed to Preview October 2, 2022 12:48 Inactive
@vercel
vercelBot temporarily deployed to Preview October 4, 2022 12:18 Inactive
@danielroedanielroe mentioned this pull request Oct 9, 2022
Merged
pi0
pi0 reviewed Oct 12, 2022
View reviewed changes
Comment threadpackages/schema/src/config/nitro.ts Outdated
@danielroe
danielroe requested a review from pi0October 14, 2022 12:46
@pi0pi0 changed the title feat(schema): add routes as shortcut for nitro.routesfeat(schema): add experimental routes as shortcut for nitro.routesOct 17, 2022
pi0
pi0 reviewed Oct 17, 2022
View reviewed changes
Comment threadpackages/schema/src/config/nitro.ts Outdated
Comment threadpackages/schema/src/config/nitro.ts Outdated
@pi0pi0 changed the title feat(schema): add experimental routes as shortcut for nitro.routesfeat(schema): add experimental routesRulesOct 17, 2022
pi0
pi0 approved these changes Oct 17, 2022
View reviewed changes
@pi0
pi0 merged commit df2bad7 into mainOct 17, 2022
@pi0
pi0 deleted the feat/schema-alias branch October 17, 2022 11:22
@danielroedanielroe changed the title feat(schema): add experimental routesRulesfeat(schema): add experimental routeRulesOct 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@atinuxatinuxatinux approved these changes
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xnitro🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressingschema

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@atinux@pi0