Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(schema): evaluate env variables when resolving values - #8079

Merged
danielroe merged 1 commit into
mainfrom
fix/build-env
Oct 10, 2022
Merged

fix(schema): evaluate env variables when resolving values#8079
danielroe merged 1 commit into
mainfrom
fix/build-env

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15123

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Previously we were evaluating the default values when the @nuxt/schema module was evaluated. But when we are using dotenv we mutate process.env later on. So this makes sure that the app env variables can be updated.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working schema labels Oct 10, 2022
@danielroedanielroe self-assigned this Oct 10, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 10, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit0e1aec9
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6343da4eae5d3d00099d7ab5

@danielroedanielroe changed the title fix(nuxi): read in .env before evaluating schemafix(schema): evaluate env variables when resolving valuesOct 10, 2022
@danielroe
danielroe requested a review from atinuxOctober 10, 2022 09:39
@danielroe
danielroe merged commit e94c3b3 into mainOct 10, 2022
@danielroe
danielroe deleted the fix/build-env branch October 10, 2022 10:04
@danielroedanielroe mentioned this pull request Oct 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't workingschema

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting a baseURL causes Nuxi Generate to not generate html files in ./output/public

2 participants

@danielroe@atinux