Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs: add app.config route to pre-render - #8131

Merged
atinux merged 6 commits into
mainfrom
docs/404
Oct 12, 2022
Merged

docs: add app.config route to pre-render#8131
atinux merged 6 commits into
mainfrom
docs/404

Conversation

@atinux

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Add missing url not detected by crawler 🤔

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 12, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6346e24ab970b627c0d45d40
😎 Deploy Previewhttps://deploy-preview-8131--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atinux
atinux requested a review from danielroeOctober 12, 2022 10:49
@danielroe

Copy link
Copy Markdown
Member

Hm. We need to handle 404 page:

CleanShot 2022-10-12 at 12 14 37

@Tahul

Copy link
Copy Markdown
Contributor

https://github.com/nuxt/content/blob/main/src/runtime/pages/document-driven.vue

Docus has no "default" components for DocumentDrivenNotFound and DocumentDrivenEmpty components, but I guess this is the way to go for this kind of issues.

I remember that there was an "issue" (maybe this is expected behavior) with catch-all pages that was overriding the support for error pages in pages folder.

Maybe we could work around this by throwing an error in DocumentDriven page when the query fails, and then handling the 404 via Nuxt pages folder?

I also know that as pagesaren't "extendable", the only way of allowing user to overwrite was to use replaceable components (DocumentDrivenNotFound...).

@danielroe

Copy link
Copy Markdown
Member

If we have a design for a custom error page, we can provide it in ~/error.vue in this repo.

The 404 error is only being thrown on server side in docus, which means we're not redirected to it on a client-side 404 (in this case), and the console errors are coming from missing nav data (owing to not having a defined GITHUB_TOKEN) on client side. We should likely gracefully handle them as well.

@atinux

Copy link
Copy Markdown
MemberAuthor

It the comment blocking the current PR?

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is good to go 👍

@Tahul

Copy link
Copy Markdown
Contributor

Just a little info, this can only be reproduced on built version, when using dev, landing on undefined link will display 404/error page

I just locally tried creating both:

docs/error.vue
// or
docs/pages/error.vue

It doesn't had any effect in built versions, I suspect this is upstream issue as mentioned, error.vue page won't be taken in account when catch-all page already setup.

@atinux
atinux merged commit a6e4a09 into mainOct 12, 2022
@atinux
atinux deleted the docs/404 branch October 12, 2022 16:45
This was referenced Oct 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@atinux@danielroe@Tahul