Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

types: include nuxt-link target types - #8172

Merged
pi0 merged 2 commits into
nuxt:mainfrom
vencho-mdp:patch-1
Oct 13, 2022
Merged

types: include nuxt-link target types#8172
pi0 merged 2 commits into
nuxt:mainfrom
vencho-mdp:patch-1

Conversation

@vencho-mdp

@vencho-mdpvencho-mdp commented Oct 13, 2022•
edited by danielroe
Loading

Copy link
Copy Markdown
Contributor

🔗 Linked issue

resolvesnuxt/nuxt#15148

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added possible types for target value, in order to provide autocompletion.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

codesandboxBot commented Oct 13, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 13, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commite478039
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/634831ae2289090008c3403a

danielroe
danielroe reviewed Oct 13, 2022
View reviewed changes
Comment threadpackages/nuxt/src/app/components/nuxt-link.ts Outdated
@vencho-mdp@danielroe
Update packages/nuxt/src/app/components/nuxt-link.ts
e478039
Co-authored-by: Daniel Roe <daniel@roe.dev>
pi0
pi0 approved these changes Oct 13, 2022
View reviewed changes

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks <3

@pi0
pi0 merged commit 9fa147d into nuxt:mainOct 13, 2022
@vencho-mdp
vencho-mdp deleted the patch-1 branch October 13, 2022 21:15
@pi0pi0 mentioned this pull request Oct 18, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@DamianGlowalaDamianGlowalaDamianGlowala left review comments
@pi0pi0pi0 approved these changes
@danielroedanielroedanielroe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Autocompletion for the target attribute of the <NuxtLink> component

4 participants

@vencho-mdp@pi0@danielroe@DamianGlowala