Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

perf(nuxt): remove vue-router dependency from minimal app - #8188

Merged
pi0 merged 1 commit into
mainfrom
perf/router
Oct 14, 2022
Merged

perf(nuxt): remove vue-router dependency from minimal app#8188
pi0 merged 1 commit into
mainfrom
perf/router

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This removes vue-router dependency from default app (extracted from #8133). Note that there's still a dependency if using <NuxtLayout> which needs to be resolved separately.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage performance labels Oct 14, 2022
@danielroe
danielroe requested a review from pi0October 14, 2022 08:30
@danielroedanielroe self-assigned this Oct 14, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 14, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit95c5b78
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63491e1f54bbee00085b0515

pi0
pi0 approved these changes Oct 14, 2022
@pi0pi0 changed the title perf: remove vue-router dependency from minimal appperf(nuxt): remove vue-router dependency from minimal appOct 14, 2022
@pi0
pi0 merged commit 2083ed4 into mainOct 14, 2022
@pi0
pi0 deleted the perf/router branch October 14, 2022 08:36
@pi0pi0 mentioned this pull request Oct 18, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usageperformance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@atinux@pi0