Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxt)!: refresh to override previous requests by default - #8190

Merged
pi0 merged 1 commit into
mainfrom
feat/override-default
Oct 15, 2022
Merged

feat(nuxt)!: refresh to override previous requests by default#8190
pi0 merged 1 commit into
mainfrom
feat/override-default

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

#7864

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This renames override to dedupe and enables it by default, which should be more the expected behaviour.

👉 Migration

If you were relying on the previous behaviour (not re-calling a fetch function if one was already running) then you can update your refresh calls like so:

- refresh()+ refresh({ dedupe: false })

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added the enhancement New feature or request label Oct 14, 2022
@danielroe
danielroe requested a review from pi0October 14, 2022 13:19
@danielroedanielroe self-assigned this Oct 14, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 14, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit6210c22
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/634961fd5562210008bbd226
😎 Deploy Previewhttps://deploy-preview-8190--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pi0
pi0 approved these changes Oct 15, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally still believe cancel: false is easier to read than dedup: true but both are good....

@pi0
pi0 merged commit d862a6b into mainOct 15, 2022
@pi0
pi0 deleted the feat/override-default branch October 15, 2022 11:02
@pi0pi0 mentioned this pull request Oct 18, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xenhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0