Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): enable router when app/router.options.ts file is present - #8193

Merged
pi0 merged 5 commits into
nuxt:mainfrom
vencho-mdp:patch-1
Oct 15, 2022
Merged

fix(nuxt): enable router when app/router.options.ts file is present#8193
pi0 merged 5 commits into
nuxt:mainfrom
vencho-mdp:patch-1

Conversation

@vencho-mdp

@vencho-mdpvencho-mdp commented Oct 14, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

🔗 Linked issue

resolvesnuxt/nuxt#15163

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

If the user provides a router.options file, the module should be enabled, even without a pages dir.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

codesandboxBot commented Oct 14, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 14, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitf01594b
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63499659a24dfd0008b2c4af
😎 Deploy Previewhttps://deploy-preview-8193--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0

pi0 commented Oct 14, 2022

Copy link
Copy Markdown
Member

Thanks for this improvement. Enabling module with custom router makes sense!

Do you mind fixing lint issue?

@vencho-mdp

vencho-mdp commented Oct 14, 2022

Copy link
Copy Markdown
ContributorAuthor

Sure!

pi0
pi0 reviewed Oct 14, 2022
View reviewed changes
Comment threaddocs/content/2.guide/2.directory-structure/1.pages.md Outdated
@vencho-mdp@pi0
Update docs/content/2.guide/2.directory-structure/1.pages.md
f01594b
Co-authored-by: pooya parsa <pyapar@gmail.com>
pi0
pi0 approved these changes Oct 15, 2022
View reviewed changes
@pi0pi0 changed the title fix(pages): add module when router.options is presentfix(nuxt): enable router when app/router.options.ts file is presentOct 15, 2022
@pi0
pi0 merged commit b9d6f37 into nuxt:mainOct 15, 2022
@pi0

pi0 commented Oct 15, 2022

Copy link
Copy Markdown
Member

Thanks!

@vencho-mdp
vencho-mdp deleted the patch-1 branch October 15, 2022 12:27
@pi0pi0 mentioned this pull request Oct 18, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using only router.options.ts should enable page mode

3 participants

@vencho-mdp@pi0@danielroe