Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

refactor(nuxt): use h3 early hints util - #8245

Merged
pi0 merged 3 commits into
mainfrom
refactor/h3-hint
Oct 17, 2022
Merged

refactor(nuxt): use h3 early hints util#8245
pi0 merged 3 commits into
mainfrom
refactor/h3-hint

Conversation

@danielroe

@danielroedanielroe commented Oct 17, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This uses new h3 writeEarlyHints util: h3js/h3#184

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added the 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing label Oct 17, 2022
@danielroe
danielroe requested a review from pi0October 17, 2022 09:02
@danielroedanielroe self-assigned this Oct 17, 2022
@codesandbox

codesandboxBot commented Oct 17, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 17, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit92228e2
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/634d1b23b9b3560007d01dc5

pi0
pi0 reviewed Oct 17, 2022
View reviewed changes
Comment threadpackages/nuxt/src/core/runtime/nitro/renderer.ts Outdated
@danielroe@pi0
fix: remove check
92228e2
Co-authored-by: pooya parsa <pyapar@gmail.com>
pi0
pi0 approved these changes Oct 17, 2022
View reviewed changes
@pi0
pi0 merged commit 9388e65 into mainOct 17, 2022
@pi0
pi0 deleted the refactor/h3-hint branch October 17, 2022 09:16
@pi0pi0 mentioned this pull request Oct 18, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.x🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0