Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxt): allow disabling early hints - #8264

Merged
pi0 merged 2 commits into
mainfrom
feat/early-hints-disable
Oct 17, 2022
Merged

feat(nuxt): allow disabling early hints#8264
pi0 merged 2 commits into
mainfrom
feat/early-hints-disable

Conversation

@danielroe

@danielroedanielroe commented Oct 17, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

#8067 (comment)

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Just in case of any problems, this allows disabling early hints (#7893) in the Nuxt server. Also following up with fix in h3 for underlying issue.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added the enhancement New feature or request label Oct 17, 2022
@danielroe
danielroe requested a review from pi0October 17, 2022 19:38
@danielroedanielroe self-assigned this Oct 17, 2022
@codesandbox

codesandboxBot commented Oct 17, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 17, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitc489f53
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/634db8cc51f3b6000a3665a9

johannschopplich
johannschopplich reviewed Oct 17, 2022
View reviewed changes
Comment threadpackages/schema/src/config/experimental.ts Outdated
@pi0
pi0 merged commit 96a8807 into mainOct 17, 2022
@pi0
pi0 deleted the feat/early-hints-disable branch October 17, 2022 20:20
@pi0pi0 mentioned this pull request Oct 18, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pi0pi0Awaiting requested review from pi0
1 more reviewer
@johannschopplichjohannschopplichjohannschopplich left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xenhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@pi0@johannschopplich