Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(kit): addVitePluginaddWebpackPlugin support plugin array - #8270

Merged
pi0 merged 2 commits into
mainfrom
feat/add-vite-plugin-array
Oct 18, 2022
Merged

feat(kit): addVitePluginaddWebpackPlugin support plugin array#8270
pi0 merged 2 commits into
mainfrom
feat/add-vite-plugin-array

Conversation

@antfu

@antfuantfu commented Oct 18, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

#8265

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

An array of plugins is also a valid Vite plugin, we should support that.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

codesandboxBot commented Oct 18, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 18, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit1a682ce
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/634e6cb7bedf0700092855d5

@pi0

pi0 commented Oct 18, 2022

Copy link
Copy Markdown
Member

Shall we support for addWebpackPlugin too?

@antfuantfu changed the title feat(kit): addVitePlugin supports plugin arrayfeat(kit): addVitePluginaddWebpackPlugin support plugin arrayOct 18, 2022
@antfu

antfu commented Oct 18, 2022

Copy link
Copy Markdown
MemberAuthor

Unplugin's Webpack plugin behaviours like one so we don't directly need it, but sure why not. Changed pushed.

pi0
pi0 approved these changes Oct 18, 2022
View reviewed changes
@pi0
pi0 merged commit 6567ac3 into mainOct 18, 2022
@pi0
pi0 deleted the feat/add-vite-plugin-array branch October 18, 2022 09:09
@pi0pi0 mentioned this pull request Oct 18, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@pi0pi0pi0 approved these changes
@danielroedanielroedanielroe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antfu@pi0@danielroe