Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

chore(nuxt): add type for headers - #8326

Merged
pi0 merged 1 commit into
mainfrom
chore/headers-type
Oct 19, 2022
Merged

chore(nuxt): add type for headers#8326
pi0 merged 1 commit into
mainfrom
chore/headers-type

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 🧹Chore
  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This casts incoming headers to HeadersInit and resolves lint issue. @pi0 can you confirm that this is valid (ie. that the actual type of these headers is assignable in fetch) or do we need to normalise them instead?

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
danielroe requested a review from pi0October 19, 2022 13:12
@danielroedanielroe self-assigned this Oct 19, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 19, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit35550ae
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/634ff7d69a28660007654798

@pi0

pi0 commented Oct 19, 2022

Copy link
Copy Markdown
Member

Added h3 improvement to normalize. Will improve after release. (h3js/h3@d141f81)

@pi0
pi0 merged commit 3333ef8 into mainOct 19, 2022
@pi0
pi0 deleted the chore/headers-type branch October 19, 2022 13:28
@pi0pi0 mentioned this pull request Oct 19, 2022
7 tasks
@pi0pi0 mentioned this pull request Nov 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0