Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): invalidate virtual modules with vite-node - #8389

Merged
pi0 merged 1 commit into
mainfrom
fix/invalidate-vite-node
Oct 24, 2022
Merged

fix(vite): invalidate virtual modules with vite-node#8389
pi0 merged 1 commit into
mainfrom
fix/invalidate-vite-node

Conversation

@danielroe

@danielroedanielroe commented Oct 21, 2022•
edited
Loading

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15141, resolvesnuxt/nuxt#15045

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We invalidate virtual files in the vite server whenever templates are regenerated. But hitherto we weren't invalidating them in vite-node.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Oct 21, 2022
@danielroe
danielroe requested review from antfu and pi0October 21, 2022 11:57
@danielroedanielroe self-assigned this Oct 21, 2022
@codesandbox

codesandboxBot commented Oct 21, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 21, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitae6f8ef
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63528914fa992900093326ed

@danielroedanielroe mentioned this pull request Oct 22, 2022
Closed
pi0
pi0 approved these changes Oct 24, 2022
View reviewed changes
@pi0
pi0 merged commit 4536242 into mainOct 24, 2022
@pi0
pi0 deleted the fix/invalidate-vite-node branch October 24, 2022 08:32
@pi0pi0 mentioned this pull request Nov 3, 2022
Merged
@danielroedanielroe mentioned this pull request Jan 23, 2023
Merged
7 tasks
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@pi0pi0pi0 approved these changes
@antfuantfuantfu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagevite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Routes not registered when page file created router not updating with new routes on HMR

3 participants

@danielroe@pi0@antfu